Added DeepCopy to replace __clone implementations #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bilge
force-pushed
the
master
branch
5 times, most recently
from
01c8862
to
d8cd138
Compare
|
Seems the issue with DeepCopy has been resolved so this is no longer on hold. |
Bilge
force-pushed
the
master
branch
3 times, most recently
from
c394a43
to
372f181
Compare
Bilge
force-pushed
the
master
branch
2 times, most recently
from
2308bb2
to
37b143d
Compare
Bilge
force-pushed
the
master
branch
11 times, most recently
from
4cd0ac5
to
5b2d2be
Compare
Bilge
force-pushed
the
master
branch
26 times, most recently
from
8df01f3
to
4cd4dbd
Compare
Bilge
force-pushed
the
master
branch
4 times, most recently
from
93ce095
to
5898b4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes implementing DeepCopy to avoid placing the burden on users to implement
__clonein their transformers. However, that library currently suffers from a blocking issue (myclabs/DeepCopy#62) that prevents its adoption.