Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build with rollup + babel, namespace, modal style #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mila76
Copy link

@mila76 mila76 commented Jan 16, 2022

editorconfig + prettier for consistency
namespace default option
default/type style for modal

editorconfig + prettier for consistency
namespace default option
default/type style for modal
Copy link
Author

@mila76 mila76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but the diff is so huge because different writing style and prettier do prettier stuff
the actual code difference is very small

N.B. sorry not tested in node

@mila76 mila76 changed the title build with rollup + babel build with rollup + babel, namespace, modal style Jan 16, 2022
@Script47
Copy link
Owner

@mila76

I will take a look at this I've just been quite busy this week.

Let's hope things clear up the at the backend of this week.

@mila76
Copy link
Author

mila76 commented Jan 20, 2022

In my branch i put some other small "fix":
in snake i removed fixed border and add icon option similar to toast

take your time there is no hurry
i have other small ideas (not implemented because work great as is for my user case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants