Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarr: Add version 2.4 #13320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

yarr: Add version 2.4 #13320

wants to merge 3 commits into from

Conversation

amreus
Copy link
Contributor

@amreus amreus commented May 20, 2024

Adding https://github.com/nkanaev/yarr feed reader.

Closes #13055

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

yarr

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@qwertyhjklxyz
Copy link

add environment variables to make the data portable.

"env_set": {
    "YARR_DB": "$dir\\data\\storage.db",
    "YARR_LOGFILE": "$dir\\data\\yarr.log"
},
"persist": "data"

@amreus amreus marked this pull request as draft May 28, 2024 07:11
@amreus
Copy link
Contributor Author

amreus commented May 28, 2024

add environment variables to make the data portable.

"env_set": {
    "YARR_DB": "$dir\\data\\storage.db",
    "YARR_LOGFILE": "$dir\\data\\yarr.log"
},
"persist": "data"

Yes that is good - I did not see these variables documented anywhere, and had to search through the source code. I will add a command line shim also since these are options that can be set via command line.
Thanks.

@amreus
Copy link
Contributor Author

amreus commented May 28, 2024

add environment variables to make the data portable.

"env_set": {
    "YARR_DB": "$dir\\data\\storage.db",
    "YARR_LOGFILE": "$dir\\data\\yarr.log"
},
"persist": "data"

A couple things.

Why persist a log file?

When yarr.exe is shimmed, it no longer prints anything to the output in the terminal. Any idea why or how to fix?

@qwertyhjklxyz
Copy link

Why persist a log file?

As you said, when yarr.exe is shimmed, it no longer prints anything.
But it works fine when the scoop shim is configured as scoopcs.

@amreus
Copy link
Contributor Author

amreus commented May 28, 2024

But it works fine when the scoop shim is configured as scoopcs.

I am not familiar with scoopcs. I can find no manifest in Main or Extras with the term.

I do see a reference in core.ps1 but that doesn't explain too much. There is apparently different shims that can be specified? How to use it? Thanks.

@qwertyhjklxyz
Copy link

qwertyhjklxyz commented May 28, 2024

This needs to be configured manually by the user.

scoop config shim scoopcs

the log file can be non-persistent.

"YARR_LOGFILE": "$dir\\yarr.log"

it's better to set the log file path, because opening yarr from a shortcut doesn't pop up the terminal to output logs.

@amreus amreus marked this pull request as ready for review June 5, 2024 21:04
@amreus
Copy link
Contributor Author

amreus commented Jun 5, 2024

/verify

Copy link
Contributor

github-actions bot commented Jun 5, 2024

All changes look good.

Wait for review from human collaborators.

yarr

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: Yarr
2 participants