Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KakaoTalkAdBlock: Add version 2.1.4 #12968

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oxjihun
Copy link

@oxjihun oxjihun commented Mar 18, 2024

Adds KakaoTalkAdBlock (2.0.0) to the bucket.

Closes #12883

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • Description
  • License
  • Hashes
  • Checkver

@oxjihun
Copy link
Author

oxjihun commented Mar 18, 2024

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • Description
  • License
  • Hashes
  • Checkver

@aliesbelik
Copy link
Collaborator

aliesbelik commented Mar 30, 2024

@oxjihun Please add autoupdate section and 32bit version as well.

@oxjihun
Copy link
Author

oxjihun commented May 30, 2024

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik changed the title KakaoTalkAdBlock: Add version 2.0.0 KakaoTalkAdBlock: Add version 2.1.4 May 31, 2024
@aliesbelik
Copy link
Collaborator

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

kakaotalkadblock

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik
Copy link
Collaborator

Virustotal reports a lot of problems:
https://www.virustotal.com/gui/file/951e277d65ac26c15437c24f0cd40983690321c104c491791035a420d62f8623

Even if false positive (blurfx/KakaoTalkAdBlock#83, blurfx/KakaoTalkAdBlock#85), guess this could cause problems on installation via scoop, when antivirus blocks installation or quarantines downloaded binaries in case of threat detection.

@oxjihun
Copy link
Author

oxjihun commented May 31, 2024

@aliesbelik I apologize for making a pull request for a possibly malicious app.

To get things straight, I'd have to admit that I was partially aware of this. When writing the manifest for version 2.0.0, Windows Defender's inhibition was the main reason I couldn't include the 32bit version. There was no problem with 64bit version though. Since the program was regionally well known (at least I thought so), I regarded the 64bit version as safe. Never considered of running VirusTotal.

And yesterday, when writing the manifest for version 2.1.4, Windows Defender didn't raise any issues for downloading both 32bit and 64bit versions. I vaguely assumed that the false positive got fixed. Therefore, I proceeded to make a second commit.

Now I come to think of it, for transparency, I must have elaborated any issues upon opening the pull request. As this is my first time contributing to a large project on GitHub, I am still learning how to contribute 'well'. Though I know this is a mere excuse. I deeply apologize for all this inconvenience.

According to blurfx/KakaoTalkAdBlock#85 (comment), the dev managed to get the 2.1.4 version binaries removed from the malware detection list. With this, is there any chance that this manifest could be added to the Extras bucket?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: KakaoTalkAdBlock
2 participants