Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --ignore-dependencies with stack_output #779

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ngfgrant
Copy link
Contributor

@ngfgrant ngfgrant commented Jul 4, 2019

This commit fixes an issue where a users attempts to launch a single
stack that utilises the stack_output_resolver with the
--ignore-dependencies.

Previously, with --ignore-dependencies set, any dependencies that arose
through !stack_output_resolver would not be added to
stack.dependencies and the next() function in
StackOutput.resolve() would raise a StopIteration as the
stack.dependencies list would be empty.

This commit handles the stack_output by utilising the argument passed
into stack_output.

[Resolves #778]

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (make test) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes flake8 (make lint) checks.
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

This commit fixes an issue where a users attempts to launch a single
stack that utilises the `stack_output_resolver` with the
`--ignore-dependencies`.

Previously, with `--ignore-dependencies` set, any dependencies that arose
through `!stack_output_resolver` would not be added to
`stack.dependencies` and the `next()` function in
`StackOutput.resolve()` would raise a `StopIteration` as the
stack.dependencies list would be empty.

This commit handles the stack_output by utilising the argument passed
into `stack_output`.

[Resolves #778]
@ngfgrant ngfgrant force-pushed the fix-single-stack-ignore-dep-stack-output branch from 638e7a8 to 905a0d6 Compare July 4, 2019 11:33
@ngfgrant
Copy link
Contributor Author

ngfgrant commented Jul 4, 2019

There maybe an issue with this implementation as it assumes the region and profile of the stack in stack_output is the same as the stack calling it.

@ngfgrant
Copy link
Contributor Author

ngfgrant commented Jul 5, 2019

I can confirm that it is an issue :/

@ngfgrant ngfgrant marked this pull request as draft April 18, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: launch single stack with !stack_output and --ignore-dependencies
1 participant