-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolve #1114] Project Dependencies WIP: Identifying stack as project dependency #1155
Open
jfalkenstein
wants to merge
223
commits into
master
Choose a base branch
from
jf/proj-dependencies-p4-project-dependency-config
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Resolve #1114] Project Dependencies WIP: Identifying stack as project dependency #1155
jfalkenstein
wants to merge
223
commits into
master
from
jf/proj-dependencies-p4-project-dependency-config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jf/proj-dependencies-p3-iam-role-property
…-dependencies-p4a-placeholders
jfalkenstein
changed the title
[Resolve #1114] Project Dependencies part 4: Identifying stack as project dependency
[Resolve #1114] Project Dependencies WIP: Identifying stack as project dependency
Dec 12, 2021
…pendencies-p4-project-dependency-config
… jf/proj-dependencies-p6-docs-and-integration-tests
Base automatically changed from
jf/proj-dependencies-p3-iam-role-property
to
master
December 28, 2021 22:17
…es-p4-project-dependency-config
…proj-dependencies-p6-docs-and-integration-tests
…proj-dependencies-p4-project-dependency-config
…s-p4-project-dependency-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on hold
In discussion with @zaro0508 and @zxiiro, we decided this aspect of addressing #1114 would be put on hold until the resolver work is finished.
This is the Fourth in a series of pull requests that addresses #1114 , allowing Sceptre to manage its own dependencies.
In this PR:
is_project_dependency: True
. This is important, as it allows us to bypass the irreconcilable issue of multiple project dependency stacks depending on each other. Withis_project_dependency: True
, it will have the effects of:template_bucket_name: !stack_output bucket.yaml::BucketName
, and that would include the bucket.yaml stack, which cannot rely on itself.[Resolve #issue-number]
.make test
) are passing.pre-commit run --all-files
).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit