0.5 Release #292
Merged
0.5 Release #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously deprecated and we received no feedback to keep it in. I also updated the podman python binding to the newly active name.
* Fix file logging level issue. Fixes #223 * Patch awx logging to allow trace logging in all cases.
* added optional label support * provider/container - support labels, skip envars as labels * label formatting logic moved to commands.py * labels arg renamed to provider-labels * labels - AT provider - fix label value parsing * add provider_label support to execute command * fix provider_labels parsing for container provider * provider_labels are nested for AT provider * append label asserts to test_container_e2e * Add parsing of eventual settings.provider_labels for AT, Container providers * add e2e provider_labels fn test for AA
Instead of wrapping everything under a single ProviderError, let's add some nuance.
This change fills the gap previously seen for podman's inability execute commands on containers. A large part of this was handling the returned output from podman's exec_run, which is a tuple containing the return code and a bytes string containing both the stdout and stderr. Due to this, we needed to implement a demuxer. Also made some minor tweaks to the functional tests
|
@JacobCallahan Do you think we could get this #291 into the 0.5 release? |
|
@dosas With the recent updates made to that PR, it is highly likely that it will make it in to 0.5. This PR is based on that branch so anything merged before this will make it in. |
There are cases, like github actions, where it is preferable for broker's settings to come from a local repo clone than from github. This change starts with a check for the local clone with a fallback to the source on github.
* Add foreman broker * add example settings for Foreman broker * Reorganize classes - Rename ForemanAPI to ForemanBind - Put Foreman Bind in a separate file - Create exception for FormanBind - Make internal method private - Add method to query hostgroup information * Apply organizational changes in tests too * Get rid of constructor call in provider_help * Hotfix for github action --------- Co-authored-by: Jan Bundesmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all the changes currently in the 0.5 branch.