Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematic): add generate excel manifest endpoint #2569

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andrewelamb
Copy link
Contributor

@andrewelamb andrewelamb commented Mar 15, 2024

  • fixes FDS-1605
  • adds generate excel manifest endpoint
  • removes input validation from generate google sheets manifest endoint (functionality moved to schematic)
  • removed defaults from generate google sheets manifest endoint (to help testing)
  • files for runing the API locally added to gitignore file

Copy link

sonarcloud bot commented Mar 15, 2024

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-app'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-challenge-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-organization-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed for 'openchallenges-image-service'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewelamb I think users need to be able to download the excel file as an attachment. When I tried the endpoint you made, by using the default parameters, I saw:
Screen Shot 2024-03-19 at 6 30 53 PM

This is not the expected behavior because front-end apps like DCA can't read files downloaded on the schematic side. They can't read from file path: "/workspaces/sage-monorepo/apps/schematic/api/Example.Patient.manifest.xlsx" and get the manifest as an excel file. In summary, Schematic APIs would need to forward the excel file somehow to the front-end app when the endpoint gets called and can't just forward a path.

@tschaffter
Copy link
Member

@andrewelamb Is this PR still relevant?

@andrewelamb
Copy link
Contributor Author

@tschaffter Yes, I'm hoping to get back to this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sonar-scan-approved-deprecated Ready for Sonar code analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants