Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components/molecule/select): combination between input and dropdown-list sizes #2742

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

andresin87
Copy link
Member

Molecule/Select

🔍 Show

TASK:

Description, Motivation and Context

Dropdownlist was not height scroll cropped due to a bad mapping of the props

Types of changes

  • 🪲 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🧾 Documentation
  • 📷 Demo
  • 🧪 Test
  • 🧠 Refactor
  • 💄 Styles
  • 🛠️ Tool

Screenshots - Animations

Copy link

STATEMENTS BRANCHES FUNCTIONS LINES
≍ 0.01↑ ≍ 0= ≍ 0= ≍ 0=
% 75.97 64.37 65.95 77.74
ABS 3339 / 4395 2044 / 3175 653 / 990 3161 / 4066

@andresin87 andresin87 merged commit 23a0359 into master Jun 13, 2024
7 checks passed
@andresin87 andresin87 deleted the fix-select-sizes-prop branch June 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants