[FEAT] migrate atom/label to TS #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikoruiz
commented
May 13, 2024
components/atom/label/src/index.tsx
Outdated
| @@ -0,0 +1,57 @@ | |||
| /* eslint-disable react/prop-types */ | |||
There was a problem hiding this comment.
We need to update the lint config for TS files in order to remove this rule, not needed anymore.
|
|
kikoruiz
commented
May 14, 2024
components/atom/label/mod.d.ts
Outdated
There was a problem hiding this comment.
Pending to be moved to root directory.
kikoruiz
commented
May 14, 2024
components/atom/label/index.d.ts
Outdated
There was a problem hiding this comment.
Pending to be moved to root directory.
kikoruiz
changed the title
ferransimon
reviewed
May 15, 2024
components/atom/label/src/index.tsx
Outdated
| */ | ||
| text: string | ||
| /** | ||
| * Allows label to be displayed inline to de left |
There was a problem hiding this comment.
Typo Allows label to be displayed inline to de left -> Allows label to be displayed inline to the left
ferransimon
reviewed
May 15, 2024
components/atom/label/src/index.tsx
Outdated
| /** | ||
| * Allows label to be displayed inline to de left | ||
| */ | ||
| inline?: string |
There was a problem hiding this comment.
I see in the code that this prop can be either left or right so maybe we can add some Type checking with these 2 values instead of using a string.
There was a problem hiding this comment.
Yep, it makes sense, it's not used for any other reason ;)
carlosvillu
approved these changes
May 15, 2024
|
|
quinwacca
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate the first component (
AtomLabel) to TypeScript. Behaviour of the component remains the same.Type of changes
Complete list of changes:
AtomLabelmigration to TypeScript.