Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Fixed Expired JWT Token By Refreshing it #1353

Merged
merged 7 commits into from
May 28, 2024
Merged

馃悰 Fixed Expired JWT Token By Refreshing it #1353

merged 7 commits into from
May 28, 2024

Conversation

Aibono1225
Copy link
Member

@Aibono1225 Aibono1225 commented May 24, 2024 •
edited

Relates to #1340

Changes:

  • Enabled refresh tokens for all APIs requiring authorization
  • Added a prompt to "log in again" if the refresh token expires

image
Figure: Settings in Auth0 dashboard

@Aibono1225 Aibono1225 marked this pull request as ready for review May 27, 2024 01:23
@Aibono1225 Aibono1225 requested review from JackDevAU and bradystroud and removed request for JackDevAU May 27, 2024 01:23
@Aibono1225 Aibono1225 requested a review from JackDevAU May 27, 2024 06:26
bradystroud
bradystroud approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@bradystroud bradystroud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I assume the AUTH0_SCOPE has been added to the github secrets so it works on production

@Aibono1225
Copy link
Member Author

LGTM I assume the AUTH0_SCOPE has been added to the github secrets so it works on production

Yes they are now in github variables 馃檪

@Aibono1225 Aibono1225 merged commit fbbbaa3 into main May 28, 2024
5 checks passed
@Aibono1225 Aibono1225 deleted the implement-refresh-token branch May 28, 2024 01:02
Aibono1225 added a commit that referenced this pull request May 30, 2024
@Aibono1225
Revert "馃悰 Fixed Expired JWT Token By Refreshing it (#1353)"
9f62655 
This reverts commit fbbbaa3.
@Aibono1225 Aibono1225 mentioned this pull request May 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradystroud bradystroud bradystroud approved these changes

@JackDevAU JackDevAU JackDevAU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Aibono1225 @bradystroud @JackDevAU