馃悰 Fix Incorrect Default Title in Page Source #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aibono1225
changed the title
JackDevAU
previously approved these changes
May 23, 2024
JackDevAU
reviewed
May 23, 2024
src/components/head/head.js
Outdated
Comment on lines
22
to
29
| const titles = { | ||
| '/latest-rules/': 'Latest Rules', | ||
| '/user/': 'User Rules', | ||
| '/orphaned/': 'Orphaned Rules', | ||
| '/archived/': 'Archived Rules', | ||
| '/profile/': 'Profile', | ||
| }; | ||
|
|
There was a problem hiding this comment.
Would it be worth moving this to a config file?
JackDevAU
reviewed
May 27, 2024
src/helpers/config/pageTitles.js
Outdated
Comment on lines
1
to
9
| const titles = { | ||
| '/latest-rules/': 'Latest Rules', | ||
| '/user/': 'User Rules', | ||
| '/orphaned/': 'Orphaned Rules', | ||
| '/archived/': 'Archived Rules', | ||
| '/profile/': 'Profile', | ||
| }; | ||
|
|
||
| export default titles; |
There was a problem hiding this comment.
Should we move this to https://github.com/SSWConsulting/SSW.Rules/blob/main/site-config.js
Just so its all in one spot?
JackDevAU
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1333
This PR fixes the issue where the default
<title>in the page source was incorrect for some pages.Figure: Orphaned Rule
Figure: Homepage