Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mixed integer KPLSK #607

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add Mixed integer KPLSK #607

merged 2 commits into from
Jul 5, 2024

Conversation

Paul-Saves
Copy link
Contributor

@Paul-Saves Paul-Saves commented Jun 28, 2024 •
edited
Loading

  • Add Mixed integer KPLSK for CR & GD kernels

@Paul-Saves
[update KPLSK mixed: krg_based & test. Add a boolean for testing second loop.

relf
relf requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@relf relf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo the 'ruff' commit, ruff formatting when touching numerous files has to be done in a separate dedicated PR.

@Paul-Saves
Copy link
Contributor Author

Ruff in #608

@Paul-Saves Paul-Saves marked this pull request as draft June 28, 2024 15:35
@Paul-Saves Paul-Saves closed this Jul 4, 2024
@Paul-Saves Paul-Saves reopened this Jul 4, 2024
@Paul-Saves Paul-Saves marked this pull request as ready for review July 4, 2024 09:03
@relf relf merged commit 49f8bd8 into SMTorg:master Jul 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relf relf relf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Paul-Saves @relf