Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the skills and projects dynamically and customizable #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make the skills and projects dynamically and customizable #148

wants to merge 2 commits into from

Conversation

abdellatif-laghjaj
Copy link

This change improves the abillity of the user to easily customize the skills and projects data, by adding and changing a JSON file

x9nico
x9nico suggested changes Aug 26, 2022
View reviewed changes
Copy link

@x9nico x9nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could remove the divs you commented at line 152 to 163 in index.html file ? Like that, the code will be more clean up and comprehensive :)

@abdellatif-laghjaj
Copy link
Author

Done ✔️

@abdellatif-laghjaj abdellatif-laghjaj marked this pull request as draft June 20, 2023 20:10
@abdellatif-laghjaj abdellatif-laghjaj marked this pull request as ready for review June 20, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x9nico x9nico Awaiting requested review from x9nico

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abdellatif-laghjaj @x9nico