Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have modified the docker.yml GitHub action that is used to build and publish the Dockerfile to DockerHub. For quite a while, the check would fail on PRs and releases. This is likely due to the action changing/DockerHub API changing since we implemented the workflow on our end.
I have now used a different action and configured the docker.yml workflow to:
Run when a new release is made; this will tag it as
rustscan/rustscan:1.11.11
on DockerHub, for exampleIt now successfully runs when a PR is made. However, the Dockerfile is only built, and isn't actually published. Otherwise, this means our DockerHub will be full of tags such as
rustscan/rustscan:pr-400
, but building it is important for CI/CD purposes, and the check will fail if it fails to compile RustScan.It will now run when a merge or commit is made to the
master
branch, this will result in alatest
tag being published to DockerHub, so people can try out new features/updates without having to wait for an official release.Use a DockerHub access token (repo secret) to login to DockerHub instead of DockerHub Account Password
I've tested it on my end with a demo repository and new DockerHub repo:
cmnatic/githubtest
, but we will need to see how it works out for rustscan/rustscan :)TODO: figure out how we can determine "what is stable" to create a "stable" tag for #533. Maybe this is just a re-tag of the latest release.