Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new test system for name resolution 2.0 #3010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

powerboat9
Copy link
Contributor

This should allow us to more easily test and record progress on name resolution 2.0

@powerboat9
Copy link
Contributor Author

powerboat9 commented May 18, 2024

Note that, until name resolution 2.0 improves sufficiently, a decent fraction of new tests after this is merged (?) will have to be entered into the exclude file.

@powerboat9 powerboat9 force-pushed the test-nr2 branch 2 times, most recently from 95d701d to ad118fa Compare May 18, 2024 21:21
This runs the standard compile/*.rs tests
with name resolution 2.0 enabled. The exclude file
can be used to exclude tests which are not yet working
with name resolution 2.0.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/compile.exp: New test.
	* rust/compile/nr2/exclude: New.

Signed-off-by: Owen Avery <[email protected]>
@powerboat9 powerboat9 marked this pull request as ready for review June 4, 2024 01:43
@CohenArthur
Copy link
Member

@powerboat9 I like the implementation and I think this feature makes sense, but I'm not sure if it's going to make our life easier in the long run. I'm in favor of merging it if the rest of the community thinks it is a good idea. it does add a burden which is maintaining and revisiting that exclude file. but the alternative is also annoying, as we'd need to add a copy of existing testcases with -frust-name-resolution-2.0 added as an argument...

maybe we can do something like keep the nr2 folder, run it with different dejagnu options but only keep symlinks to testcases that pass under NR2.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants