Add a new CI step for windows environments #2979
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-E-P
force-pushed
the
add_windows_ci
branch
8 times, most recently
from
08143f7
to
76059e5
Compare
P-E-P
force-pushed
the
add_windows_ci
branch
6 times, most recently
from
7bb7c81
to
c7842c7
Compare
P-E-P
force-pushed
the
add_windows_ci
branch
11 times, most recently
from
2549f88
to
17ed2a8
Compare
.github/workflows/ccpp.yml
Outdated
| run: | ||
| shell: msys2 {0} | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
Suggested change
| - uses: actions/checkout@v3 | |
| - uses: actions/checkout@v4 |
| --enable-multilib | ||
| - name: Build | ||
| run: | | ||
| make -C gccrs-build -j1 # $(nproc) |
There was a problem hiding this comment.
gcc could be built in parallel on mingw-w64.
There was a problem hiding this comment.
This is only because I don't have any windows machine, it is longer but build output are not merged, this was not meant to be merged as is but rather as a way to untangle the output from a system I do not use much.
ChangeLog: * .github/workflows/ccpp.yml: Signed-off-by: Pierre-Emmanuel Patry <[email protected]>
|
We'll need #2949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new CI step on Windows to ensure the project compiles on this platform with mingw.
Motivation: During upstreaming process we discovered some
dlsymcode was incorrectly disabled, the project does not compile using mingw anymore.