Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 3.5, 3.6, 3.7, 3.8, 3.9, and 3.10 support; black; GitHub Actions; upgrade deps #81

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

SamuelMarks
Copy link

New features / changes (thus far):

  • Switch to black formatting
  • Upgrade all dependencies
  • Remove Travis and AppVeyor
  • Add new shields, remove all ones
  • Integrate GitHub Actions
  • Conditionally add/remove typings that are only valid for Python < 3.6
  • Make [many of] the tests work on 3.5, 3.6, 3.7, 3.8, 3.9, and 3.10
  • Add support for Literal (PEP586)

…mports, replace CI with GitHub Actions, modify README.md
…e/parsers.py] Include previous `TYPE_PARSERS` if < 3.6
…longer set on a special `__enforcer__` attribute; [nodes.py] Use `typing.Literal` over old actual literal annotation
…ent for `literal`; [*.py] black; use `object` base class
…requirements{_build.txt,.txt}] Upgrade dependencies
@RussBaz
Copy link
Owner

RussBaz commented Dec 21, 2021

Hi. Thanks a lot for the pull request. I will try giving a code review (of sorts) as soon as I can, even if it is a symbolic one. I am currently traveling a bit and therefore I cannot promise how quickly I will do it. I truly hope to do so before the end of the year.

If all the old and new tests are green, I will be very happy to upload it to pypi.

@RussBaz
Copy link
Owner

RussBaz commented Dec 31, 2021

I tried running running it on a fresh installation of 3.10 but I could not make tests run due to import errors and so on. It will require reading through all the change logs since 3.5 before it can run on 3.10 . . . I think the support for anything older than 3.10 needs to be dropped in order to revive the package. Otherwise, the workload might be too much for anyone doing it as a hobby.

Any opinions?

@SamuelMarks
Copy link
Author

@RussBaz On 3.10.1 I get 55 tests passing and 27 failing. You can try python setup.py test or python -m unittest

@RussBaz
Copy link
Owner

RussBaz commented Dec 31, 2021

Hey, @SamuelMarks, I was fooling around and managed to make the test suite run. The main issue was with the line 273 in parsers.py. Replacing it for now with sys.version_info < (3, 6) fixed it for me. I got 55 failed and 1 ignored out of 178 tests. 122 tests passed. Why are we having the different number of tests? Could you check on your side again? Thanks.

PS. I am running the test suite on MacOS 12.1 with Python 3.10.1

@SamuelMarks
Copy link
Author

SamuelMarks commented Dec 31, 2021

@RussBaz Hmm… I'm at 53a4193 on macOS 12.0.1 with Python 3.10.1.

Let me try fixing the line you referenced…

EDIT: Yep, now getting same as you. Added commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants