Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: Added AddTask request API #55

Merged
merged 2 commits into from
Oct 24, 2023
Merged

✨ feat: Added AddTask request API #55

merged 2 commits into from
Oct 24, 2023

Conversation

hartmannjean
Copy link
Contributor

Issue

This pull request refers to Issue #31

  • Does not apply to this pull request

Description

Added new taskApi endpoint
Added viewmodel for AddTaskScreen
created field validation functions

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with develop (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

@hartmannjean hartmannjean requested review from OdisBy and softdevandre and removed request for OdisBy October 21, 2023 23:32
softdevandre
softdevandre approved these changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@softdevandre softdevandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

OdisBy
OdisBy approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@OdisBy OdisBy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 perfect bro

@OdisBy OdisBy added this pull request to the merge queue Oct 24, 2023
Merged via the queue into develop with commit b79fcc0 Oct 24, 2023
1 check passed
@OdisBy OdisBy deleted the feature/add-task-request-api branch October 24, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softdevandre softdevandre softdevandre approved these changes

@OdisBy OdisBy OdisBy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hartmannjean @softdevandre @OdisBy