Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Added Logout Option #53

Merged
merged 12 commits into from
Oct 18, 2023
Merged

✨ feat: Added Logout Option #53

merged 12 commits into from
Oct 18, 2023

Conversation

OdisBy
Copy link
Collaborator

@OdisBy OdisBy commented Oct 18, 2023

Issue

This pull request refers to Issue #33

  • Does not apply to this pull request

Description

  • Added Logout Action Option, button is in menu of top bar

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with develop (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

Copy link
Contributor

@softdevandre softdevandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logout button and logout action working as expected. It redirects the app to login screen after that 👍 👌

Copy link
Contributor

@hartmannjean hartmannjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

# Conflicts:
#	app/src/main/java/com/routinely/routinely/data/core/Session.kt
#	app/src/main/java/com/routinely/routinely/login/LoginViewModel.kt
#	app/src/main/java/com/routinely/routinely/navigation/SetupNavGraph.kt
#	app/src/main/java/com/routinely/routinely/ui/components/TopAppBarRoutinely.kt
@OdisBy OdisBy added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit 8f80b5c Oct 18, 2023
1 check passed
@OdisBy OdisBy deleted the feature/logout branch October 18, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants