Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat: Login API Integration #51

Merged
merged 6 commits into from
Oct 18, 2023
Merged

✨ feat: Login API Integration #51

merged 6 commits into from
Oct 18, 2023

Conversation

OdisBy
Copy link
Collaborator

@OdisBy OdisBy commented Oct 17, 2023

Issue

This pull request refers to Issue #26

  • Does not apply to this pull request

Description

  • Added Login Api endpoints
  • Added circular progress bar
  • New model for API return (SignInResult)
  • Saving if user should continue logged in DataStore Api
  • If user is logged start destination will change

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Bug fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

What changed:

  • UI
  • Business rule
  • Documentation
  • Gradle or Build
  • Navigation
  • Tests
  • Resource files
  • Project architecture
  • Code style

Checklist

  • Have tested the changes.
  • Met all the acceptance requirements of this task.
  • Verified if branch is up-to-date with develop (if not - rebase it or merge it).
  • Resolve git conflicts

If any of the acceptance criteria are not met, please explain why below

What is the criteria? Why it is different?

softdevandre
softdevandre approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@softdevandre softdevandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes working well 👌

hartmannjean
hartmannjean reviewed Oct 18, 2023
View reviewed changes
app/src/main/java/com/routinely/routinely/data/core/Session.kt
val remember = booleanPreferencesKey(REMEMBER)
}

fun getToken(): Flow<String> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function refactored on addtask request PR

hartmannjean
hartmannjean approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@hartmannjean hartmannjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@OdisBy OdisBy added this pull request to the merge queue Oct 18, 2023
Merged via the queue into develop with commit 7917a32 Oct 18, 2023
1 check passed
@OdisBy OdisBy deleted the feature/login-integration branch October 18, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartmannjean hartmannjean hartmannjean approved these changes

@softdevandre softdevandre softdevandre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OdisBy @hartmannjean @softdevandre