fix: Monitors dissapearing from Unit upon edit #32393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 79fe7e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KevLehman
force-pushed
the
fix/monitors-dissapear-on-save
branch
from
630437d
to
ba6312c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32393 +/- ##
===========================================
+ Coverage 50.70% 55.90% +5.20%
===========================================
Files 1947 2432 +485
Lines 45979 53480 +7501
Branches 9325 10993 +1668
===========================================
+ Hits 23312 29898 +6586
- Misses 20516 20950 +434
- Partials 2151 2632 +481
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
previously requested changes
May 10, 2024
KevLehman
force-pushed
the
fix/monitors-dissapear-on-save
branch
from
7b17d09
to
eafab32
Compare
dougfabris
requested changes
May 14, 2024
|
Hey @dougfabris i forgot to add a changeset before, mind to review this one again? 😬 |
dougfabris
approved these changes
May 17, 2024
MartinSchoeler
approved these changes
May 17, 2024
KevLehman
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
gabriellsh
added a commit
that referenced
this pull request
May 28, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: (36 commits) refactor: IntegrationHistory out of DB Watcher (#32502) fix: Message update being broadcasted without updated values (#32472) test: make api teams test fully independent (#31756) test: Fix test name (#32490) fix: streams being called with no logged user (#32489) feat: Un-encrypted messages not allowed in E2EE rooms (#32040) feat(UiKit): Users select (#31455) fix: Re-login same browser tab issues (#32479) chore: move all webclient code out of the COSS folders (#32273) chore(deps): bump thehanimo/pr-title-checker from 1.3.7 to 1.4.1 (#30619) fix: Don't show join default channels option for edit user form (#31750) fix: CAS user merge not working (#32444) fix: Overriding Retention Policy not working (#32454) fix: `rooms.export` endpoint generates an empty export when given an invalid date (#32364) fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow (#32398) fix: Bypass trash when removing OTR system messages and read receipts (#32269) fix: Monitors dissapearing from Unit upon edit (#32393) fix: Link image preview not opening in gallery (#32391) feat: Allow visitors & integrations to access downloaded files after a room has closed (#32439) regression: Users tab misaligned (#32451) ...
matheusbsilva137
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Introduced here: #30734
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-572
Steps to test or reproduce
Further comments
Fixed an issue that caused the UI to send an invalid _id for monitors that were already saved on the unit. This caused the BE to ignore these monitors (as the _id didn't exist) and save only the newly added items to the list (if any)
This was caused because on an old refactor, the destructuring of the
monitorsproperty changed frommonitorId(on JS) to_id(in TS)As the elements were coming from the
unit_monitorscollection instead of theuserscollection, here_idrepresented something totally different. When the BE eliminated the elements that were not valid monitors from the array, these were excluded (which is correct) and not saved.