feat: new navigation with NavBar
#32382
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32382 +/- ##
===========================================
- Coverage 56.36% 51.51% -4.85%
===========================================
Files 2434 2155 -279
Lines 53693 48515 -5178
Branches 11050 9909 -1141
===========================================
- Hits 30262 24993 -5269
- Misses 20824 21257 +433
+ Partials 2607 2265 -342
Flags with carried forward coverage won't be shown. Click here to find out more. |
juliajforesti
force-pushed
the
feat/navbar
branch
from
d644b89
to
edf28b7
Compare
juliajforesti
force-pushed
the
feat/navbar
branch
from
e6f3a08
to
6df5295
Compare
| <Box | ||
| ref={boxRef} | ||
| role='listbox' | ||
| // id={listId} |
There was a problem hiding this comment.
I would suggest creating a toolbar folder with these three toolbars separate, one file for each.
e.g NavBarPagesToolbar
|
|
||
| type OmnichannelProps = Omit<HTMLAttributes<HTMLElement>, 'is'>; | ||
|
|
||
| export const NavBarItemOmnichannelContact = (props: OmnichannelProps) => { |
There was a problem hiding this comment.
| export const NavBarItemOmnichannelContact = (props: OmnichannelProps) => { | |
| export const NavBarItemOmnichannelContact = (props: Omit<HTMLAttributes<HTMLElement>, 'is'>) => { |
| import type { HTMLAttributes } from 'react'; | ||
| import React from 'react'; | ||
|
|
||
| type OmnichannelProps = Omit<HTMLAttributes<HTMLElement>, 'is'>; |
There was a problem hiding this comment.
| type OmnichannelProps = Omit<HTMLAttributes<HTMLElement>, 'is'>; |
|
|
||
| type OmnichannelProps = Omit<HTMLAttributes<HTMLElement>, 'is'>; | ||
|
|
||
| export const NavBarItemOmnichannelQueue = (props: OmnichannelProps) => { |
There was a problem hiding this comment.
| export const NavBarItemOmnichannelQueue = (props: OmnichannelProps) => { | |
| export const NavBarItemOmnichannelQueue = (props: Omit<HTMLAttributes<HTMLElement>, 'is'>) => { |
|
|
||
| type DirectoryProps = Omit<HTMLAttributes<HTMLElement>, 'is'>; | ||
|
|
||
| export const NavBarItemDirectoryPage = (props: DirectoryProps) => { |
There was a problem hiding this comment.
| export const NavBarItemDirectoryPage = (props: DirectoryProps) => { | |
| export const NavBarItemDirectoryPage = (props: Omit<HTMLAttributes<HTMLElement>, 'is'>) => { |
| import type { HTMLAttributes, VFC } from 'react'; | ||
| import React from 'react'; | ||
|
|
||
| export const NavBarItemHomePage: VFC<Omit<HTMLAttributes<HTMLElement>, 'is'>> = (props) => { |
There was a problem hiding this comment.
| export const NavBarItemHomePage: VFC<Omit<HTMLAttributes<HTMLElement>, 'is'>> = (props) => { | |
| export const NavBarItemHomePage = (props: Omit<HTMLAttributes<HTMLElement>, 'is'>) => { |
|
|
||
| type MarketPlaceProps = Omit<HTMLAttributes<HTMLElement>, 'is'>; | ||
|
|
||
| export const NavBarItemMarketPlaceMenu = (props: MarketPlaceProps) => { |
There was a problem hiding this comment.
| export const NavBarItemMarketPlaceMenu = (props: MarketPlaceProps) => { | |
| export const NavBarItemMarketPlaceMenu = (props: Omit<HTMLAttributes<HTMLElement>, 'is'>) => { |
There was a problem hiding this comment.
I think we can throw this file in the trash 🗑️
its not being used since we're not going to have it under feature preview
|
The 
|
|
Additionally, I found small issues using RTL language:
|
SIDE-35
epic tasks:
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments