feat: Un-encrypted messages not allowed in E2EE rooms #32040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eb685e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32040 +/- ##
===========================================
+ Coverage 56.23% 56.27% +0.03%
===========================================
Files 2428 2434 +6
Lines 53560 53681 +121
Branches 11031 11045 +14
===========================================
+ Hits 30122 30211 +89
- Misses 20799 20832 +33
+ Partials 2639 2638 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
gabriellsh
previously requested changes
Apr 19, 2024
There was a problem hiding this comment.
I think we could improve a little bit the e2ee state hooks. I'm mostly thinking about not having both useE2EERoomState and useIsE2EEReady.
Also since e2e is base on emitters, we could also have a function that returns the subscribe and get functions to use with useSyncExternalStore.
Maybe let's have a chat sometime about all the E2EE feature/code?
matheusbsilva137
previously approved these changes
May 16, 2024
hugocostadev
previously approved these changes
May 16, 2024
yash-rajpal
dismissed stale reviews from hugocostadev and matheusbsilva137
via
aa81aab
KevLehman
reviewed
May 20, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
hugocostadev
previously approved these changes
May 21, 2024
hugocostadev
approved these changes
May 24, 2024
MarcosSpessatto
requested changes
May 25, 2024
gabriellsh
added a commit
that referenced
this pull request
May 28, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: (36 commits) refactor: IntegrationHistory out of DB Watcher (#32502) fix: Message update being broadcasted without updated values (#32472) test: make api teams test fully independent (#31756) test: Fix test name (#32490) fix: streams being called with no logged user (#32489) feat: Un-encrypted messages not allowed in E2EE rooms (#32040) feat(UiKit): Users select (#31455) fix: Re-login same browser tab issues (#32479) chore: move all webclient code out of the COSS folders (#32273) chore(deps): bump thehanimo/pr-title-checker from 1.3.7 to 1.4.1 (#30619) fix: Don't show join default channels option for edit user form (#31750) fix: CAS user merge not working (#32444) fix: Overriding Retention Policy not working (#32454) fix: `rooms.export` endpoint generates an empty export when given an invalid date (#32364) fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow (#32398) fix: Bypass trash when removing OTR system messages and read receipts (#32269) fix: Monitors dissapearing from Unit upon edit (#32393) fix: Link image preview not opening in gallery (#32391) feat: Allow visitors & integrations to access downloaded files after a room has closed (#32439) regression: Users tab misaligned (#32451) ...
matheusbsilva137
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Hugo Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
We allowed users to send un-encrypted messages in encrypted rooms if the users didn't had the E2EE setup or keys were missing.
Now we are introducing a setting which will not allow users to send un-encrypted messages in E2EE rooms. If the users don't have the E2EE setup or don't have room keys, it will show a new E2EE setup interface to users, using which users will be able to get a feedback regarding their E2EE status.
Also introduced the E2EE state to track in which state the E2EE functionality is in.
Issue(s)
Steps to test or reproduce
Further comments
E2EE-3