added es6 features. #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RonLek @djcruz93 Would like to get your inputs on it : ) |
RonLek
suggested changes
Jan 14, 2021
| "abdelazeem777\t" | ||
| ], | ||
| "startDate": "1970-01-15" | ||
| } |
There was a problem hiding this comment.
@Sumitraj387 You don't need to delete the config-example.json file. It's a crucial part of getting the config.json file initialized.
|
@Sumitraj387 please resolve the due conflicts as well. |
|
@Sumitraj387 I am unable to understand why only some functions are made arrow functions? It would be great since you are adding es6 features for the codebase, you can change all the functions format according. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.