Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: addition of curve design variant with customization options #581

Merged
merged 56 commits into from
Jun 3, 2024

Conversation

Spiral-Memory
Copy link
Contributor

@Spiral-Memory Spiral-Memory commented May 26, 2024

Brief Title

Acceptance Criteria Fulfillment

  • Fixed emoji popup when sidebar opens
  • Cleaned up hardcoded colors and made UI more consistent with themes
  • Fixed Totp Modal
  • Fixed bounce while closing emoji popup
  • Added flexibility to customize options in ChatHeader, Message Toolbox, and Formatting Toolbar
  • Designed Bubble Variant
  • Refactor bubble styles
  • Fix the quote and pinned message UI.

Fixes #580

Video/Screenshots

2024-06-03.17-26-41.mp4
2024-06-03.17-36-33.mp4

@Spiral-Memory Spiral-Memory marked this pull request as draft May 26, 2024 18:03
@Spiral-Memory Spiral-Memory changed the title feat: addition of a curve design variant feat: addition of Curve Design Variant with Customization Options May 28, 2024
@Spiral-Memory Spiral-Memory changed the title feat: addition of Curve Design Variant with Customization Options feat: addition of curve design variant with customization options May 28, 2024
limited to single quoting of message for simplicity
@Spiral-Memory Spiral-Memory force-pushed the feat/curve-variant branch 2 times, most recently from fa0bf25 to 738e577 Compare June 3, 2024 08:45
@Spiral-Memory Spiral-Memory marked this pull request as ready for review June 3, 2024 09:51
@Spiral-Memory Spiral-Memory force-pushed the feat/curve-variant branch 5 times, most recently from 2431843 to 97d8058 Compare June 3, 2024 10:29
@Spiral-Memory
Copy link
Contributor Author

Hey @sidmohanty11

This PR is now ready for review. I've fixed some bugs and made the menu customizable based on our discussion. Now, developers can pass the name of the option they want to keep in the theme object, and the other options will be automatically removed. If someone wants to wrap those options into a menu, they could pass a threshold, and the other options will be wrapped inside the menu.

Additionally, I've introduced the bubble variant in this PR. In each case, I've ensured that the display of attachments, thread reply button, quoting, or pinning the message matches the bubble variant.

The entire change is also explained in the attached video. Kindly review this PR. This was to add the variant for ChatBody. For Chat Input and Sidebar, I will also add variants in upcoming PRs, such as the Discord look, as per our discussion.

Thanks!

Copy link
Collaborator

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too good! This is awesome! Lets refactor this a bit in your next PR. LGTM!! 💯 🏆

@sidmohanty11 sidmohanty11 merged commit a1aa212 into RocketChat:develop Jun 3, 2024
3 checks passed
@Spiral-Memory
Copy link
Contributor Author

Too good! This is awesome! Lets refactor this a bit in your next PR. LGTM!! 💯 🏆

Thank you so much, @sidmohanty11 , for the appreciation! Glad you liked it! I'll make the necessary changes in the next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Add Curved Design Variant + Customization
2 participants