-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: addition of curve design variant with customization options #581
feat: addition of curve design variant with customization options #581
Conversation
ab29a7c
to
5d26e82
Compare
5d26e82
to
acce40d
Compare
da6f1d9
to
18223f6
Compare
18223f6
to
2efb1c7
Compare
6420d8f
to
270c5c8
Compare
02b8bf7
to
7678671
Compare
51a7fb2
to
e12d207
Compare
e12d207
to
f53aa7c
Compare
256334c
to
fab3635
Compare
limited to single quoting of message for simplicity
bec5177
to
cfd4362
Compare
fa0bf25
to
738e577
Compare
cef12fc
to
23d9c12
Compare
2431843
to
97d8058
Compare
97d8058
to
8d78294
Compare
Hey @sidmohanty11 This PR is now ready for review. I've fixed some bugs and made the menu customizable based on our discussion. Now, developers can pass the name of the option they want to keep in the theme object, and the other options will be automatically removed. If someone wants to wrap those options into a menu, they could pass a threshold, and the other options will be wrapped inside the menu. Additionally, I've introduced the bubble variant in this PR. In each case, I've ensured that the display of attachments, thread reply button, quoting, or pinning the message matches the bubble variant. The entire change is also explained in the attached video. Kindly review this PR. This was to add the variant for ChatBody. For Chat Input and Sidebar, I will also add variants in upcoming PRs, such as the Discord look, as per our discussion. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too good! This is awesome! Lets refactor this a bit in your next PR. LGTM!! 💯 🏆
Thank you so much, @sidmohanty11 , for the appreciation! Glad you liked it! I'll make the necessary changes in the next PR. |
Brief Title
Acceptance Criteria Fulfillment
Fixes #580
Video/Screenshots
2024-06-03.17-26-41.mp4
2024-06-03.17-36-33.mp4