Waller steal #2222
Open
Waller steal #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automated style fixes Co-authored-by: YellowToad3197 <[email protected]>
automated style fixes Co-authored-by: ZachB123 <[email protected]>
sid-parikh
requested changes
Mar 13, 2024
| @@ -134,7 +134,7 @@ std::optional<RobotIntent> Defense::state_to_task(RobotIntent intent) { | |||
| return intent; | |||
| } else if (current_state_ == WALLING) { | |||
| if (!walling_robots_.empty()) { | |||
| Waller waller{waller_id_, (int)walling_robots_.size()}; | |||
| Waller waller{waller_id_, robot_id_, (int)walling_robots_.size(), walling_robots_}; | |||
There was a problem hiding this comment.
Suggested change
| Waller waller{waller_id_, robot_id_, (int)walling_robots_.size(), walling_robots_}; | |
| Waller waller{waller_id_, robot_id_, static_cast<int>(walling_robots_.size()), walling_robots_}; |
| @@ -2,10 +2,12 @@ | |||
|
|
|||
| namespace strategy { | |||
|
|
|||
| Waller::Waller(int waller_num, int total_wallers) { | |||
| Waller::Waller(int waller_num, int robot_id, int total_wallers, std::vector<u_int8_t> waller_ids) { | |||
There was a problem hiding this comment.
use an initializer-list here instead. also std::move the waller_ids vector
| intent.kick_speed = 4.0; | ||
| intent.dribbler_speed = 255.0; | ||
| intent.is_active = true; | ||
| dont_kick = false; |
There was a problem hiding this comment.
can you do an early return intent; here instead of using the boolean and checking it later?
| std::vector<u_int8_t> waller_ids_; // list of wallers | ||
|
|
||
| // max distance away the ball can be from a waller for it to jump out and kick it | ||
| const float CLEAR_DIST = 0.75; |
There was a problem hiding this comment.
Suggested change
| const float CLEAR_DIST = 0.75; | |
| static constexpr float CLEAR_DIST = 0.75; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wallers will come out to kick the ball towards the opponents goal if the ball is within a certain threshold.