-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RI-5523: Fallback to non-native big integers for JSON formatting #3231
RI-5523: Fallback to non-native big integers for JSON formatting #3231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c2eb8f9
to
75d1b2e
Compare
@AmirAllayarovSofteq, Can you approve the CI job and verify it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have pointed this out in the ticket. According to the JSON specification, only big numerics are supported, not big floating-point numbers. The only way to view this is to use scientific notation (which is usually the use case for big numbers). Our vector format mostly has big floating-point numbers that use scientific notation only. @ViktarStarastsenka Maybe we can show a chip denoting that the number has been converted to scientific notation? |
@GnaneshKunal Sorry, my bad. |
@GnaneshKunal 2 - Probably in JSONViewer we should add something like this: |
…json-non-native-big-int
Done. Thanks @AmirAllayarovSofteq. That was an excellent suggestion. I have extended the support to Vector types as well: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Maybe you can add one test for _isBigNumer in JsonPretty
I have added the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Please check - https://redislabs.atlassian.net/browse/RI-5523?focusedCommentId=1793216