Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify own RedisGears allocator. #878

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iddm
Copy link
Collaborator

@iddm iddm commented Apr 6, 2023

Uses the new API of the redismodule crate to set custom global allocator.

Uses the new API of the redismodule crate to set custom global
allocator.
@iddm iddm self-assigned this Apr 6, 2023
@iddm
Copy link
Collaborator Author

iddm commented Apr 6, 2023

@MeirShpilraien This uses the new API in the redismodule macro to set the global allocator by the implementor itself, so as to be able to fully control it. The code for the changes in redismodule -rs is in this PR: RedisLabsModules/redismodule-rs#307

@iddm iddm marked this pull request as draft April 6, 2023 07:52
Copy link
Collaborator

@MeirShpilraien MeirShpilraien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vityafx This will basically create 2 allocators right? One for the core and one for plugins. I like this Idea but maybe we can take it one step forward and create an allocator per engine. It will give us more flexibility to show more per engine specific memory stats in the future. WDYT?

@iddm
Copy link
Collaborator Author

iddm commented May 1, 2023

@vityafx This will basically create 2 allocators right? One for the core and one for plugins. I like this Idea but maybe we can take it one step forward and create an allocator per engine. It will give us more flexibility to show more per engine specific memory stats in the future. WDYT?

I apologise, but I think I should ask for an example to avoid confusion. Can you please add more colours to what you said?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants