Implement the "noop" mode. #1106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a "noop" mode where the module acts like it is a fully-operational RedisGears v2 (triggers and functions) module, while in fact does nothing. It still loads the RDB, has the same commands, but the commands do not perform any action, though still can be invoked. The configuration options remain as well.
Adds the integration tests to check that the RDB file is read but nothing is taken from it.
redisgears_core/src/noop/mod.rs
Outdated
| } | ||
| )] | ||
| fn function_call(_ctx: &Context, _args: Vec<RedisString>) -> RedisResult { | ||
| RedisResult::Ok(RedisValue::Null) |
There was a problem hiding this comment.
Return some error message
redisgears_core/src/noop/mod.rs
Outdated
| } | ||
| )] | ||
| fn function_call_async(_ctx: &Context, _args: Vec<RedisString>) -> RedisResult { | ||
| RedisResult::Ok(RedisValue::Null) |
redisgears_core/src/noop/mod.rs
Outdated
| } | ||
| )] | ||
| fn function_command_on_replica(_ctx: &Context, _args: Vec<RedisString>) -> RedisResult { | ||
| RedisResult::Ok(RedisValue::Null) |
There was a problem hiding this comment.
This is an internal command between to replica and AOF, it should return a simple OK reply
redisgears_core/src/noop/mod.rs
Outdated
| } | ||
| )] | ||
| fn function_command(_ctx: &Context, _args: Vec<RedisString>) -> RedisResult { | ||
| RedisResult::Ok(RedisValue::Null) |
There was a problem hiding this comment.
Return an error message
redisgears_core/src/noop/mod.rs
Outdated
| } | ||
| )] | ||
| fn update_stream_last_read_id(_ctx: &Context, _args: Vec<RedisString>) -> RedisResult { | ||
| RedisResult::Ok(RedisValue::Null) |
There was a problem hiding this comment.
This is an internal command between to replica and AOF, it should return a simple OK reply
|
|
||
| # Stream triggers | ||
| env.cmd('xadd', 'stream1', '*', 'foo', 'bar') | ||
| env.assertEqual(env.cmd('get', 'triggers_counter'), None) |
There was a problem hiding this comment.
We should also check AOF Loading with _rg_internals.* commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "noop" mode where the module acts like it is a fully-operational RedisGears v2 (triggers and functions) module, while in fact does nothing. It still loads the RDB, has the same commands, but the commands do not perform any action, though still can be invoked. The configuration options remain as well.