Added support for post notification jobs and before delete events #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR adds support for the following new events: * `before_deleted` * `before_expired` * `before_evicted` * `before_overwritten` **Notice**: it is forbiden to perform any write operation inside those notification (and in general, inside any notification). To perform writes operations, use the new `registerPostNotificationJob` API describe bellow. The PR also add support for post notification job API. The new API allows to register a post notification job using the `registerPostNotificationJob` function, the function gets a single callback object and calls atomically when it is safe to perform a write operation. Other changes introduce in the PR: * Update the `redismodule.h` to latest version (v7.2) * Small tests adjustments * Added CI run on Redis v7.2.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds support for the following new events:
before_deletedbefore_expiredbefore_evictedbefore_overwrittenNotice: it is forbiden to perform any write operation inside those notification (and in general, inside any notification). To perform writes operations, use the new
registerPostNotificationJobAPI describe bellow.The PR also add support for post notification job API. The new API allows to register a post notification job using the
registerPostNotificationJobfunction, the function gets a single callable object and calls it atomically when it is safe to perform a write operation.Other changes introduce in the PR:
redismodule.hto latest version (v7.2)