Fix Infallible's flatMap family of operators that can return an Infallible that is not, in fact, infallible #2536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it's a big hole in the
Infallible
contract because this will a) compile b) return anInfallible
that will fail silently, without calling any subscription closures (well maybe it will callonDispose[d]
, though, but that's beside the point):There's two ways to fix this:
Infallible
streams, and that itself returnsInfallible
.ObservableConvertibleType
and itself returnsObservable
.While 1. is better for backwards compatibility, it complicates overload resolution (
Infallible
isObservableConvertibleType
), although it seems to be working in the test code I've written.As soon as the proposed change is agreed on, I'll add tests for the first and latest variants.