generic: spi: Add escape hatch for the ChipSelectPin #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are situations where the `ChipSelectPin` abstraction is not enough - for example when a user wants to use the `ChipSelectPin` as a PWM pin. To enable such usecases anyway, add an escape hatch for getting back the original `Pin<>` type that's hidden in the `ChipSelectPin`. This is unsafe, for obvious reasons.
|
Merging this anyway even though #442 should get some more attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situations where the
ChipSelectPinabstraction is not enough - for example when a user wants to use theChipSelectPinas a PWM pin.To enable such usecases anyway, add an escape hatch for getting back the original
Pin<>type that's hidden in theChipSelectPin. This is unsafe, for obvious reasons.Related to #442.