Assistants v2 #224
Closed
Assistants v2 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons, new auth methods with project key, addded audio stream as System.Stream and as encoded byte array,
# Conflicts: # OpenAI/Packages/com.openai.unity/Runtime/Threads/CreateRunRequest.cs
| @@ -15,7 +15,7 @@ public sealed class OpenAIAuthInfo : IAuthInfo | |||
| internal const string SessionKeyPrefix = "sess-"; | |||
| internal const string OrganizationPrefix = "org-"; | |||
|
|
|||
| public OpenAIAuthInfo(string apiKey, string organizationId = null) | |||
| public OpenAIAuthInfo(string apiKey, string organizationId = null, string project = null) | |||
There was a problem hiding this comment.
does this id have a prefix?
| float? temperature = null, | ||
| string language = null, | ||
| TimestampGranularity timestampGranularity = TimestampGranularity.None) | ||
| : this(audioStream, $"UserSpeech.wav", model, prompt, responseFormat, temperature, language, timestampGranularity) |
There was a problem hiding this comment.
make audioName required param
| { "OpenAI-Beta", "assistants=v1"} | ||
| { "OpenAI-Beta", "assistants=v2"} |
There was a problem hiding this comment.
these changes should be broken out into a separate PR from the projectId changes
| internal static JsonSerializerSettings JsonSerializationOptions { get; } = new() | ||
| public static JsonSerializerSettings JsonSerializationOptions { get; } = new() |
StephenHodgson
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Most of these changes are breaking and will be done in 8.x which needs to first be completed upstream in OpenAI-DotNet
That would be awesome. Do you know when version 8 will be available? |
Hard to say as I do this in my free time. |
|
Closing this in favor of #235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small rough update to v2 beta helpers with support for delta streaming and new authorization using project keys. It also includes updates to AudioTranscriptionRequest to handle encoded audio streams (I'm using Vorbis encoding in my project, which I may post later as a sample).
I don't have time to create proper test cases and documentation, so you can use this branch as a reference for future updates if you find it useful.