Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restrictions on file extensions #1050

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

XXXXRT666
Copy link
Contributor

errors won't occur due to .DS_Store files.

so now errors won't occur due to .DS_Store files.
@SapphireLab
Copy link
Contributor

Why not define AUDIO_EXTENSION in a single config file such as tools/my_utils.py and use from xxx import AUDIO_EXTENSION for reusability? It will be easier when adding new extensions or doing some modifications.
The PR might be of some use (

@XXXXRT666
Copy link
Contributor Author

XXXXRT666 commented May 6, 2024

Some of them have no try or try outside the loop, so the the code will stop running after raising the error

@RVC-Boss
Copy link
Owner

@XXXXRT666
1、image
→_→
2、这个音频文件格式列表全吗?
3、你要写成set而不是list,可以学习一下in list和in set的算法复杂度

@XXXXRT666
Copy link
Contributor Author

现在应该就涵盖了99%能见到的扩展名了,要是直接把ffmepg的支持D的搬过来也行,已经改成set了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants