Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]fix tmpfs bug #8970

Merged
merged 7 commits into from
Jun 13, 2024
Merged

[fix]fix tmpfs bug #8970

merged 7 commits into from
Jun 13, 2024

Conversation

zhuzhuzhus
Copy link
Contributor

@zhuzhuzhus zhuzhuzhus commented May 21, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

在测试文件系统时发现在将/etc下的文件拷贝到/tmp下时:
能够正常读出文件,但是写入的时候就会有问题
在将/tmp下的文件拷贝至/tmp文件夹下时,读写都会出现问题,所以推断出tmpfs下读写都会出现问题,所以用qemu跟了一下读写该文件系统的过程。

你的解决方案是什么 (what is your solution)

tmp文件系统读写过程中,执行dfs_tmpfs_read时,由于file->vnode->size是无符号类型,所以在进行if(count < file->vnode->size - ops)这一步时会导致如果size小于ops时,减出来的数不是负数,而是一个非常大的正数,这样会导致即使文件没有内容读了。也会执行memcpy(buf, &(d_file->data[*pos]), length);这个函数,进而导致内存报错,所以在该函数中强制转换了一部分数据类型,目前运行正常,我编写了一个utest在rt-thread/examples/utest/testcases/dfs/tmpfs目录下,目前已经可以正常通过测试。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp/qenu-vir64-aarch64
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zhuzhuzhus
❌ zhujiale


zhujiale seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zhuzhuzhus zhuzhuzhus closed this May 21, 2024
@zhuzhuzhus zhuzhuzhus reopened this May 21, 2024
@zhuzhuzhus zhuzhuzhus closed this May 21, 2024
@zhuzhuzhus zhuzhuzhus reopened this May 21, 2024
@Rbb666 Rbb666 changed the title [fix]fixtmpfs bug [fix]fix tmpfs bug Jun 3, 2024
Comment on lines 47 to 49
LOG_E("errno=%d, ret=%d\n", errno, ret);
LOG_E("cp test test1 error");
uassert_false(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很多缩进有问题。建议装个 clangd 之类的,提交之前自动调整一下。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已重新在vscode中修改

@BernardXiong BernardXiong merged commit 1869c54 into RT-Thread:master Jun 13, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants