Add test reproducing a section of qmcpack that exercises many OpenMP … #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…threads executing target regions multiple times.
jplehr
reviewed
Sep 25, 2023
Comment on lines
+16
to
+19
| run: $(TESTNAME) | ||
| export OMP_NUM_THREADS=128 | ||
| $(RUNENV) $(RUNPROF) ./$(TESTNAME) 2>&1 | tee [email protected] | ||
| unset OMP_NUM_THREADS |
There was a problem hiding this comment.
Custom run rules should be handled via a RUNCMD variable.
This variable is invoked automatically from the top-level Makefile for both run and check.
You can check any of the veccopy-ompt test cases for an example.
| omp_alloctrait_t pinned_trait[1] = {{omp_atk_pinned, omp_atv_true}}; | ||
| omp_allocator_handle_t pinned_alloc = omp_init_allocator(omp_default_mem_space, 1, pinned_trait); | ||
| for(int t = 0; t < times; t++) { | ||
| #pragma omp parallel num_threads(128) |
There was a problem hiding this comment.
Should we have this hardcoded in here, or should we rely on the runtime environment for it to be set?
I would prefer the latter, as we may want to run this as part of our testing on smaller machines as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…threads executing target regions multiple times.