Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icon for google sleep plugin #134

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

this-Aditya
Copy link
Member

Updated the icon or google sleep plugin.

@this-Aditya this-Aditya changed the base branch from master to dev July 18, 2023 14:05
@this-Aditya
Copy link
Member Author

Screenshot_20230718-193634

Copy link
Member

@blootsvoets blootsvoets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps this would be a good generalization to add to the provider
fun imageResource(state: T?): Int
where each provider can implement their own image resource. For most devices that would be battery, but for others it can be just an icon.

@this-Aditya
Copy link
Member Author

Sure, thanks! I will update the Provider class soon.

@yatharthranjan
Copy link
Member

Is this superseded by #135 ?

@this-Aditya
Copy link
Member Author

this-Aditya commented May 9, 2024

Hi, it doesn't. The supporting PR for #135 -> RADAR-base/radar-commons-android#437 was closed because it was not working for every plugin.

@yatharthranjan
Copy link
Member

Ok in that case, do we need to add more cases here for the other google plugins?

@this-Aditya
Copy link
Member Author

this-Aditya commented May 9, 2024

As Joris suggested, it would be nice if generalized via radar-commons-android, and then each plugin can update its icon itself. Is it okay if I try to make it work in another PR again?

@yatharthranjan
Copy link
Member

ok, that would be great, thanks.

@this-Aditya
Copy link
Member Author

Added new PR here -> #141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants