Skip to content
This repository has been archived by the owner on Nov 28, 2020. It is now read-only.

Remove folder blur option #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bolencki13
Copy link

As requested here I have added an option to remove the folder blur behind the icons. I have tested on 8.4 and can confirm it works. Not sure if earlier iOS versions are supported.

@Qusic
Copy link
Owner

Qusic commented Sep 4, 2015

Thanks for that but there is still work to do before this can be merged.

  • Use CaptainHook instead of Logos. It doesn't seem good to mix them up.
  • Keep the code style and naming style consistent.
  • Avoid unnecessary mode changes.
  • Split changes into smaller commits.
  • You don't need to bump the package version.

Or if you are not in hurry, I can get these done later. I am quite busy with my internship and Auxo recently.

@bolencki13
Copy link
Author

If you aren't terribly busy, it might be better if you do it. Having never
worked with CaptainHook before, only in understanding what was written in
this tweak, it might be a little messy if I rewrite it myself.

On Thu, Sep 3, 2015 at 10:35 PM, Bang Lee [email protected] wrote:

Thanks for that but there is still work to do before this can be merged.

  • Use CaptainHook instead of Logos. It doesn't seem good to mix them
    up.
  • Keep the code style and naming style consistent.
  • Avoid unnecessary mode changes.
  • Split changes into smaller commits.
  • You don't need to bump the package version.

Or if you are not in hurry, I can get these done later. I am quite busy
with my internship and Auxo recently.


Reply to this email directly or view it on GitHub
#2 (comment).

Brian Olencki
[email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants