Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change access modifiers for futures month lookup collections #8028

Closed

Conversation

Romazes
Copy link
Collaborator

@Romazes Romazes commented May 15, 2024

Description

This Pull Request modifies the access modifiers for the _futuresMonthCodeLookup and _futuresMonthLookup collections, making them accessible from outside their containing class.

Related Issue

N/A

Motivation and Context

The motivation behind this change is to allow access to these lookup collections from other classes or modules within the project. Currently, they are declared with the default access modifier, limiting their visibility to only within the containing class. By changing the access modifiers to public, other parts of the codebase can utilize these collections without needing to expose the entire containing class.

Requires Documentation Change

N/A

How Has This Been Tested?

This change has been tested locally by ensuring that other classes within the project can successfully access and utilize the _futuresMonthCodeLookup and _futuresMonthLookup collections after the access modifier modification. Unit tests covering the functionality of these collections have also been executed to verify that the changes do not introduce any regressions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Romazes Romazes closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant