Update to support new LeetCode UI (regular problems) #464

Ahmed-Shukri02 · 2022-12-27T23:40:14Z

LeetHub currently does not work with the new UI used by LeetCode. This is due to the fact that document queries no longer work now that classnames, ids and components are different. This is a fix to part of the problem and still needs developing, hence this being on the dev branch.

The only file I updated (other than a change in extension name for development in manifest.json) is leetcode.js. There are 2 new functions added as well as an update to loader() (not completed), parseQuestion() and parseStats():
RegExKeyMatch() // Line 442
parsePercentileNew() // Line 548
The function of these are explained in the code. Other than these files, nothing was updated and so the updates shown on the PR are a reflection of previous updates in main

The result of this is that LeetHub can now parse question details and submission statistics from both the old (left) and new (right) UI.

The formatting for the question description is different when using the new UI (text format compared to html), and so may need further formatting or a work-around.

This by no means completely fixes the issue but is what I'd call first steps in accommodating the new UI. I'm currently working on other functions such as getProblemNameSlug() and parseCode() to support this but first need to check if the current fixes are good or not.

New Year's push

"look" is missing in the sentence "Your LeetHub portfolio could like this!"

Added leading zeros to titles

* Update gfg.js Fix QasimWani#307 * Review update * 0.0.9 * Update `output` window `querySelector` The old selector element gets removed from the DOM when the output window close is closed.

Ahmed-Shukri02 · 2022-12-29T14:47:32Z

So I've worked more with leetcode.js and have managed to get LeetHub working for regular problems
With the new UI, LeetHub can now:

Parse question details, including: question name, question id, question difficulty and question description
Parse statistics of submission: Time (both abs and percentile) and Memory (both abs and percentile)
Get code submission
Upload README.md and respective code file to GitHub

There are still many features to work on though, including

Get code submission for explore section
Get notes for regular problems

For now, however, this is a working fix to #366 #461

tamalCodes

LGTM ✅✅

QasimWani · 2023-01-05T16:06:17Z

awesome stuff @Ahmed-Shukri02. Could you perhaps also add the spinner? No worries if not, i can add that functionality.
regarding notes: i think it's better not to include them. most leetcode users don't use notes. This has been my experience after scanning hundreds of public LeetHub repos. let's leave it for now and make the common cast fast!

Ahmed-Shukri02 · 2023-01-05T21:43:00Z

Sure, I could look into that and get it working pretty soon.

And for the notes, I didn't include it in the commit message but I also added an optional choice for users to upload notes. I could remove it if not necessary:

By the way, have you guys considered modularisation of the codebase for ease of development? Now that there are two versions of leetcode to deal with, it may be easier to have them in seperate modules

Ahmed-Shukri02 · 2023-01-07T22:13:14Z

awesome stuff @Ahmed-Shukri02. Could you perhaps also add the spinner? No worries if not, i can add that functionality. regarding notes: i think it's better not to include them. most leetcode users don't use notes. This has been my experience after scanning hundreds of public LeetHub repos. let's leave it for now and make the common cast fast!

@QasimWani I've just added the spinner feature for the new UI:

I've yet to work on the explore section though, and on some questions when I want to upload I get a 422 status code from github's API:

With the response message:

'Invalid request.\n\nFor 'properties/sha', nil is not a string.'

This is a question-consistent thing, not a random occurrence. It's also present on both versions of leetcode. What do you think may be the cause of this?

Ahmed-Shukri02 · 2023-01-18T19:25:30Z

Hi @QasimWani, can this update be merged into main since a lot of people are waiting for the new update?

predict-woo · 2023-01-20T12:44:13Z

@Ahmed-Shukri02 can you make a fork for people to use? The author doesn't seem to be responding to any pull requests.

Ahmed-Shukri02 · 2023-01-20T16:04:40Z

@Ahmed-Shukri02 can you make a fork for people to use? The author doesn't seem to be responding to any pull requests.

I have a public fork that you can use now. I've left instructions on using this on your local machine in this comment

QasimWani · 2023-01-20T16:06:43Z

Hey sorry guys. Will check this over the weekend and hopefully have it merged before Monday. Thanks for being patient with me!

ibnsamy96 · 2023-01-25T06:44:08Z

Thanks @Ahmed-Shukri02 for your fantastic work on the extension. I really liked how you focused on adding support for the new design and I hope for your changes to be merged soon ^^

I found an issue to highlight, If I resubmit another solution to a previous problem, it isn't always pushed to the repo. It'll only be pushed if I refresh the page before the resubmission. And sometimes it shows the green check mark without pushing.
It's my first time using the extension so I don't know if it was happening with the old design too.

codentacos · 2023-01-25T22:59:37Z

Thanks @Ahmed-Shukri02 for your fantastic work on the extension. I really liked how you focused on adding support for the new design and I hope for your changes to be merged soon ^^

I found an issue to highlight, If I resubmit another solution to a previous problem, it isn't always pushed to the repo. It'll only be pushed if I refresh the page before the resubmission. And sometimes it shows the green check mark without pushing. And It's my first time using the extension so I don't know if it was happening with the old design too.

I feel like this could be a separate bug ticket. At least getting this PR merged would get the extension compatible with the new UI.

Ahmed-Shukri02 · 2023-01-27T11:09:23Z

I found an issue to highlight, If I resubmit another solution to a previous problem, it isn't always pushed to the repo. It'll only be pushed if I refresh the page before the resubmission. And sometimes it shows the green check mark without pushing. It's my first time using the extension so I don't know if it was happening with the old design too.

Thanks @ibnsamy96 for the good catch. Since in the new UI, you could switch tabs and revisit the accepted page, I didn't want LeetHub to upload to github multiple times, so I added a boolean that toggles on submission.

Once submitted, the boolean would cause LeetHub to stop checking for accepted submissions by exiting from the function early:

This was really just a quick fix and so meant that the script had to be reloaded for every submission. This could be considered as a bug or a feature I guess. Either way, I agree with @codentacos that we should try and get this merged as soon as possible then maybe file an issue

codentacos · 2023-01-29T21:40:49Z

Any update's about when this can get merged? @QasimWani

yuletide · 2023-02-13T20:12:35Z

Any updates? Would be nice to have this working again.

officialpiyush · 2023-02-14T14:34:14Z

any updates on this?

it was my first time using the extension, and after linking I was looking for the upload button, but couldn't figure out how to. when I checked the issues, then I realized that it is an issue because of LeetHub's UI change 😣

Rehmankk360 · 2023-02-16T16:30:14Z

@QasimWani Please Merge this , Its fixed in this PR , I checked

alexeyantropov · 2023-02-17T16:29:25Z

@QasimWani, could you merge it?

codentacos · 2023-02-21T16:18:06Z

I feel like this repo needs an additional maintainer who can merge PR's

userAugustos · 2023-02-24T20:56:26Z

Another 2 issues open, that are related to this PR.
Maybe an additional maintainer is really necessary, btw i have teste by local, as Ahmed suggest in this issue and it's working as well.

#503 this error, and the 3 before, would be solved by this PR

yuletide · 2023-02-27T17:44:27Z

Not a good sign 😅 https://twitter.com/qasim31wani/status/1617170664271613955?s=20

We just need this merged, another maintainer seems like a great idea if Qasim is open to it

codentacos · 2023-02-28T20:41:04Z

Not a good sign 😅 twitter.com/qasim31wani/status/1617170664271613955?s=20

We just need this merged, another maintainer seems like a great idea if Qasim is open to it

I have seen before when a project is no longer maintained someone fork's it and maintains a new version of it. Something along those lines. Although if he needs motivation he could charge $1 a month for licenses to use it then he gets $30K MRR. Would that be motivation enough? 👀

yuletide · 2023-02-28T20:57:51Z

@codentacos yes I think a fork is a good idea, if he is not able to maintain or willing to add access for others. It's too bad.

QasimWani · 2023-02-28T21:26:03Z

hey guys. sorry just saw this. Am talking to few OG LeetHub developers to take most of the responsibility of my shoulders. should have an update the next few days!

thegarvitrai · 2023-03-05T14:13:13Z

Hey @QasimWani. Let us know if you're looking for any help, we all can give a hand

ibnsamy96 · 2023-03-09T23:43:25Z

I hope to update the manifest file to v3 before merging

QasimWani and others added 23 commits December 31, 2021 20:27

Merge pull request QasimWani#172 from QasimWani/webstore

1355500

New Year's push

updating config

fa7a16a

adding gfg difficulty level + explore card commit message

50a483c

linting grg

7430506

revert permissions

b4af770

Fix typo in README

e3ad2d3

Merge pull request QasimWani#191 from a-aznar/patch-1

63b48ec

Update README.md

328a1ce

Update README.md

f788fc1

Update README.md

1f99699

Update README.md

1b4be19

Fix missing word in readme

0b5ac5f

"look" is missing in the sentence "Your LeetHub portfolio could like this!"

Merge pull request QasimWani#272 from bpires/patch-1

a36191a

Added leading zeros to titles

15320ac

Update leetcode.js

55eb480

Merge pull request QasimWani#348 from benlowenthal/main

1c53d70

Added leading zeros to titles

Update gfg.js (QasimWani#310)

8db4314

* Update gfg.js Fix QasimWani#307 * Review update * 0.0.9 * Update `output` window `querySelector` The old selector element gets removed from the DOM when the output window close is closed.

updating mversion

b46b4d5

added mozilla addon link to the readme (QasimWani#392)

e7d6dd5

Update README.md

8b7e560

Updated question and stats parsers to accomodate LeetCode's new UI

e56eb14

fixed new UI bug for regular leetcode problems

3539c63

fixed bugs

c8374db

Ahmed-Shukri02 changed the title ~~Update to question description and question stats parsers to accommodate new LeetCode UI~~ Update to support new LeetCode UI (regular problems) Dec 29, 2022

Ahmed-Shukri02 mentioned this pull request Dec 29, 2022

New LeetCode UI #366

Open

Ahmed-Shukri02 added 2 commits December 30, 2022 20:01

Adding feature for quesiton title caching

62194df

Fixed bugs; Added new caching system

096e683

tamalCodes approved these changes Jan 5, 2023

View reviewed changes

sozerodev added a commit to sozerodev/LeetHub that referenced this pull request Jan 6, 2023

QasimWani#464 변경사항 적용

0073aad

insert upload progress icon

225edf4

Therason mentioned this pull request Feb 13, 2023

The Extension Isn't supporting New LeetCode UI. Please Fix This Issue #496

Open

userAugustos mentioned this pull request Mar 1, 2023

LeetCode #499

Open

theopn mentioned this pull request Sep 3, 2023

Code not pushed to github on solving #578

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to support new LeetCode UI (regular problems) #464

Update to support new LeetCode UI (regular problems) #464

Ahmed-Shukri02 commented Dec 27, 2022 •

edited

Ahmed-Shukri02 commented Dec 29, 2022 •

edited

tamalCodes left a comment

QasimWani commented Jan 5, 2023 •

edited

Ahmed-Shukri02 commented Jan 5, 2023 •

edited

Ahmed-Shukri02 commented Jan 7, 2023 •

edited

Ahmed-Shukri02 commented Jan 18, 2023

predict-woo commented Jan 20, 2023

Ahmed-Shukri02 commented Jan 20, 2023

QasimWani commented Jan 20, 2023

ibnsamy96 commented Jan 25, 2023 •

edited

codentacos commented Jan 25, 2023

Ahmed-Shukri02 commented Jan 27, 2023

codentacos commented Jan 29, 2023

yuletide commented Feb 13, 2023

officialpiyush commented Feb 14, 2023

Rehmankk360 commented Feb 16, 2023 •

edited

alexeyantropov commented Feb 17, 2023

codentacos commented Feb 21, 2023

userAugustos commented Feb 24, 2023 •

edited

yuletide commented Feb 27, 2023 •

edited

codentacos commented Feb 28, 2023

yuletide commented Feb 28, 2023

QasimWani commented Feb 28, 2023

thegarvitrai commented Mar 5, 2023

ibnsamy96 commented Mar 9, 2023

Update to support new LeetCode UI (regular problems) #464

Are you sure you want to change the base?

Update to support new LeetCode UI (regular problems) #464

Conversation

Ahmed-Shukri02 commented Dec 27, 2022 • edited

Ahmed-Shukri02 commented Dec 29, 2022 • edited

tamalCodes left a comment

Choose a reason for hiding this comment

QasimWani commented Jan 5, 2023 • edited

Ahmed-Shukri02 commented Jan 5, 2023 • edited

Ahmed-Shukri02 commented Jan 7, 2023 • edited

Ahmed-Shukri02 commented Jan 18, 2023

predict-woo commented Jan 20, 2023

Ahmed-Shukri02 commented Jan 20, 2023

QasimWani commented Jan 20, 2023

ibnsamy96 commented Jan 25, 2023 • edited

codentacos commented Jan 25, 2023

Ahmed-Shukri02 commented Jan 27, 2023

codentacos commented Jan 29, 2023

yuletide commented Feb 13, 2023

officialpiyush commented Feb 14, 2023

Rehmankk360 commented Feb 16, 2023 • edited

alexeyantropov commented Feb 17, 2023

codentacos commented Feb 21, 2023

userAugustos commented Feb 24, 2023 • edited

yuletide commented Feb 27, 2023 • edited

codentacos commented Feb 28, 2023

yuletide commented Feb 28, 2023

QasimWani commented Feb 28, 2023

thegarvitrai commented Mar 5, 2023

ibnsamy96 commented Mar 9, 2023

Ahmed-Shukri02 commented Dec 27, 2022 •

edited

Ahmed-Shukri02 commented Dec 29, 2022 •

edited

QasimWani commented Jan 5, 2023 •

edited

Ahmed-Shukri02 commented Jan 5, 2023 •

edited

Ahmed-Shukri02 commented Jan 7, 2023 •

edited

ibnsamy96 commented Jan 25, 2023 •

edited

Rehmankk360 commented Feb 16, 2023 •

edited

userAugustos commented Feb 24, 2023 •

edited

yuletide commented Feb 27, 2023 •

edited