Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated leetcode.js #378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated leetcode.js #378

wants to merge 3 commits into from

Conversation

sidd5449
Copy link

Made changes to the findCode function in leetcode.js to return the submission URL according to the new Leetcode classnames.

Made changes to the findCode function in leetcode.js to return the submission URL according to new Leetcode classnames.
@sidd5449 sidd5449 closed this Oct 21, 2022
@sidd5449 sidd5449 reopened this Oct 21, 2022
Copy link

@saipavanbhanu saipavanbhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have to maintain two different codes for supporting both the old and new leetcode ui ?
@sidd5449 or you can handle both the scenarios basing on some condition and support both new and old leetcode ui.
because leetcode is releasing the changes incrementally to global world. ( all users will not be on the new leetcode ui )

@sidd5449
Copy link
Author

sidd5449 commented Nov 4, 2022

don't we have to maintain two different codes for supporting both the old and new leetcode ui ? @sidd5449 or you can handle both the scenarios basing on some condition and support both new and old leetcode ui. because leetcode is releasing the changes incrementally to global world. ( all users will not be on the new leetcode UI )

Yeah that needs to be considered. I'll work on that!

@saipavanbhanu
Copy link

@sidd5449 any update ?
because lot of users are waiting to use it on new UI. ( at the same time it should work on old UI as well ).

@saipavanbhanu
Copy link

if you want, we can sync on google meet to review and push the code.

@QasimWani
Copy link
Owner

sorry guys, i've been burned with a lot of work lately. i'll set aside some time this week to fix this issue. can one of you please list the relevant classes that have access to data of interest (ReadMe, code, submission stats)?

@sidd5449
Copy link
Author

@sidd5449 any update ? because lot of users are waiting to use it on new UI. ( at the same time it should work on old UI as well ).

I'm yet to work on it. I was caught up in some work recently and didn't get time to work on this issue.

@sidd5449
Copy link
Author

sorry guys, i've been burned with a lot of work lately. i'll set aside some time this week to fix this issue. can one of you please list the relevant classes that have access to data of interest (ReadMe, code, submission stats)?

Can you please specify what you need?

scripts/leetcode.js Outdated Show resolved Hide resolved
scripts/leetcode.js Outdated Show resolved Hide resolved
@saipavanbhanu
Copy link

Tested your PR for leetcode new UI. And it's not working.
That is the reason @QasimWani hasn't merged your pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants