Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored arguments.py to utilize argparse for command-line argument parsing. #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arncv
Copy link

@arncv arncv commented Oct 6, 2023

Refactored arguments.py to utilize argparse for command-line argument parsing.

  • Replaced manual argument parsing with argparse.
  • Specified types and default values for each argument using argparse.
  • Handled missing arguments by providing default values.

This refactoring aims to address the concerns raised in issue #138.

@nalbion
Copy link
Contributor

nalbion commented Oct 8, 2023

There are a lot of other areas in the code with refer to project.args['some_key'] often they're not even mentioned in arguments.py

@LeonOstrez LeonOstrez closed this Oct 10, 2023
@LeonOstrez LeonOstrez reopened this Oct 10, 2023
@LeonOstrez
Copy link
Member

sorry @arncv I accidentally closed PR. As @nalbion mentioned there are multiple places in code where we are using args['some_key'] and that should be changed also

@nalbion nalbion linked an issue Oct 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor arguments.py to use argparse
3 participants