Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor arguments.py to use argparse #138

Open
nalbion opened this issue Oct 6, 2023 · 5 comments · May be fixed by #141 or #521
Open

refactor arguments.py to use argparse #138

nalbion opened this issue Oct 6, 2023 · 5 comments · May be fixed by #141 or #521
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@nalbion
Copy link
Contributor

nalbion commented Oct 6, 2023

argparse makes it easier to provide help/documentation on the command line and also provides choices, default and type

It also returns an object rather than a dict. There are currently arg options scattered throughout the code which are not mentioned in arguements.py
@nalbion nalbion added documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers labels Oct 6, 2023
@arncv
Copy link

arncv commented Oct 6, 2023

I'd like to work on this issue.

@arncv arncv linked a pull request Oct 6, 2023 that will close this issue
Open
@jakob1379
Copy link

Why not use typer for an even better experience, auto documented cli and IMHO much more beautiful.

@Charu-Mittal12
Copy link

how to access this file arguments.py?

@nalbion
Copy link
Contributor Author

nalbion commented Oct 9, 2023

@Charu-Mittal12 https://github.com/Pythagora-io/gpt-pilot/blob/main/pilot/utils/arguments.py

@nalbion nalbion linked a pull request Oct 13, 2023 that will close this issue
Refactored arguments.py to utilize argparse for command-line argument parsing. #141
Open
@Yugma2605 Yugma2605 linked a pull request Jan 11, 2024 that will close this issue
Open
@Borda
Copy link

Borda commented Apr 27, 2024

how about using Fire - https://github.com/google/python-fire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
5 participants
@nalbion @Borda @jakob1379 @arncv @Charu-Mittal12