Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Overall type-hinting improvements #2457

Merged
merged 21 commits into from
Jun 5, 2024
Merged

fix: Overall type-hinting improvements #2457

merged 21 commits into from
Jun 5, 2024

Conversation

yoggys
Copy link
Contributor

@yoggys yoggys commented May 17, 2024 •
edited

Summary

Overall code type-hinting improvements.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@yoggys yoggys requested a review from a team as a code owner May 17, 2024 21:10
@yoggys
Copy link
Contributor Author

yoggys commented May 17, 2024

I think I caught most of what was wrong, this PR overwrites #2456 at the same time because I transferred the changes to this branch (so if it's ok then that one can be closed).

@yoggys yoggys marked this pull request as draft May 18, 2024 00:33
@plun1331 plun1331 mentioned this pull request May 18, 2024
Closed
9 tasks
@plun1331 plun1331 added this to the v2.6 milestone May 18, 2024
@plun1331 plun1331 removed the request for review from CodeWithSwastik May 18, 2024 04:10
@plun1331 plun1331 added bug Something isn't working priority: low Low Priority status: in progress Work in Progess labels May 18, 2024
@yoggys
Copy link
Contributor Author

yoggys commented May 18, 2024

@plun1331 by now it should be all there, you can look at it at your free time

yoggys
yoggys commented May 18, 2024
View reviewed changes
discord/interactions.py Outdated Show resolved Hide resolved
@yoggys yoggys marked this pull request as ready for review May 18, 2024 13:50
@pullapprove4 pullapprove4 bot requested a review from FrostByte266 May 18, 2024 13:51
plun1331
plun1331 reviewed May 18, 2024
View reviewed changes
discord/audit_logs.py Show resolved Hide resolved
discord/client.py Outdated Show resolved Hide resolved
discord/cog.py Outdated Show resolved Hide resolved
discord/commands/core.py Show resolved Hide resolved
discord/context_managers.py Outdated Show resolved Hide resolved
NeloBlivion
NeloBlivion suggested changes May 18, 2024
View reviewed changes
discord/client.py Outdated Show resolved Hide resolved
discord/context_managers.py Outdated Show resolved Hide resolved
discord/guild.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/monetization.py Outdated Show resolved Hide resolved
discord/state.py Outdated Show resolved Hide resolved
@yoggys yoggys requested a review from Dorukyum May 20, 2024 09:15
plun1331
plun1331 previously approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust that you've double checked that these are all correct

Dorukyum
Dorukyum requested changes May 29, 2024
View reviewed changes
discord/types/onboarding.py Outdated Show resolved Hide resolved
@yoggys yoggys requested a review from Dorukyum May 29, 2024 17:04
@yoggys yoggys requested a review from plun1331 May 29, 2024 17:04
Dorukyum
Dorukyum requested changes May 29, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yoggys @Dorukyum
Update CHANGELOG.md
70b6cdb 
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: YoggieS <[email protected]>
@yoggys yoggys requested a review from Dorukyum May 29, 2024 18:46
@Dorukyum Dorukyum enabled auto-merge (squash) June 5, 2024 20:48
@Dorukyum Dorukyum merged commit 61cc544 into Pycord-Development:master Jun 5, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@FrostByte266 FrostByte266 Awaiting requested review from FrostByte266

@NeloBlivion NeloBlivion Awaiting requested review from NeloBlivion

@plun1331 plun1331 Awaiting requested review from plun1331

Assignees
No one assigned
Labels
bug Something isn't working priority: low Low Priority status: in progress Work in Progess
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoggys @NeloBlivion @plun1331 @Dorukyum