fix: always cast PartialMessage(able) IDs to int #2406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was initially a PR to fix broken views sent in create_thread, but it turned out to be an underlying issue... once again with string IDs still being present in some areas of the library.
ForumChannel.create_thread
used the raw string ID for the ViewStore key, resulting in it always failing to resolve. Instead of castingint
here, I opted to forcePartialMessage
andPartialMessageable
to always convert toint
.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.