-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow create_dispatch method that raises exceptions #2965
Closed
dblanchette
wants to merge
67
commits into
PyGithub:main
from
coveord:fix/workflow-dispatch-with-exception
Closed
Add workflow create_dispatch method that raises exceptions #2965
dblanchette
wants to merge
67
commits into
PyGithub:main
from
coveord:fix/workflow-dispatch-with-exception
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support full GitHub app authentication
…-registration-token Add call to get registration token for self-hosted actions runner
Add Job object for workflows
Add call to list repository secrets
Co-authored-by: Jonathan Piché <[email protected]>
Add support for organization secrets
add missing method
missing id in Job
implement org runner calls
Add property to get HTTP credentials from authenticated client
Feature/implement calls from 1997
Fix create_or_update_secret type hint
DT-4874 // clear pyjwt vulnerability
* Added Secret Scanning Alert call to Repository
* fix typing mistakes created from wrong imports
merged remote back with origin
Feat/workflow run logs
add the `created` param
dblanchette
force-pushed
the
fix/workflow-dispatch-with-exception
branch
from
May 7, 2024 18:45
fd817e2
to
75a4893
Compare
Broke the PR by rebasing our fork, I opened #2966 as a replacement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been having issues with creating workflow dispatch with missing/too many arguments.
When using Workflow.create_dispatch(), we only get a boolean response even though the GitHub API returns detailed error messages.
This creates a new method that returns an exception with the error data when it fails. I did that not to break the existing method.