Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return values to Team operations where the API specifies a return value, but we didn't honor it so far #2956

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add return values to Team operations where the API specifies a return value, but we didn't honor it so far #2956

wants to merge 1 commit into from

Conversation

jdelic
Copy link
Contributor

@jdelic jdelic commented Apr 22, 2024

These are just small improvements.

Specifically:

  • Adding a team membership returns the same schema/data structure as getting a team membership, so we should return a Membership instance.
  • Deleting a team and removing a team membership both return HTTP 204 on success and so, like other examples in the API, these methods should return a bool to show whether they were succesful.

@jdelic jdelic force-pushed the feature/add-team-return-values branch from bebcdb4 to f5d5190 Compare April 22, 2024 11:33
@jdelic jdelic force-pushed the feature/add-team-return-values branch from f5d5190 to 20d17da Compare April 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jdelic