Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include bypass allowances in RequiredPullRequestReviews #2875

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Include bypass allowances in RequiredPullRequestReviews #2875

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
963de6d
Update RequiredPullRequestReviews.py to include bypass_pull_request_a…
harshita-gupta Jan 17, 2024
e53f599
fix case erorr in github app class name
harshita-gupta Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
49 changes: 41 additions & 8 deletions github/RequiredPullRequestReviews.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@

import github.NamedUser
import github.Team
import github.GithubApp
from github.GithubObject import Attribute, CompletableGithubObject, NotSet

if TYPE_CHECKING:
Expand All @@ -60,8 +61,8 @@ def _initAttributes(self) -> None:
self._dismiss_stale_reviews: Attribute[bool] = NotSet
self._require_code_owner_reviews: Attribute[bool] = NotSet
self._required_approving_review_count: Attribute[int] = NotSet
self._users: Attribute[list[NamedUser]] = NotSet
self._teams: Attribute[list[Team]] = NotSet
self._dismissal_users: Attribute[list[NamedUser]] = NotSet
self._dismissal_teams: Attribute[list[Team]] = NotSet

def __repr__(self) -> str:
return self.get__repr__(
Expand Down Expand Up @@ -94,23 +95,38 @@ def url(self) -> str:

@property
def dismissal_users(self) -> list[NamedUser]:
self._completeIfNotSet(self._users)
return self._users.value
self._completeIfNotSet(self._dismissal_users)
return self._dismissal_users.value

@property
def dismissal_teams(self) -> list[Team]:
self._completeIfNotSet(self._teams)
return self._teams.value
self._completeIfNotSet(self._dismissal_teams)
return self._dismissal_teams.value

@property
def bypass_pull_request_allowances_users(self) -> list[NamedUser]:
self._completeIfNotSet(self._bypass_pull_request_allowances_users)
return self._bypass_pull_request_allowances_users.value

@property
def bypass_pull_request_allowances_teams(self) -> list[Team]:
self._completeIfNotSet(self._bypass_pull_request_allowances_teams)
return self._bypass_pull_request_allowances_teams.value

@property
def bypass_pull_request_allowances_apps(self) -> list[github.GithubApp.GithubApp]:
self._completeIfNotSet(self._bypass_pull_request_allowances_apps)
return self._bypass_pull_request_allowances_apps.value

def _useAttributes(self, attributes: dict[str, Any]) -> None:
if "dismissal_restrictions" in attributes: # pragma no branch
if "users" in attributes["dismissal_restrictions"]:
self._users = self._makeListOfClassesAttribute(
self._dismissal_users = self._makeListOfClassesAttribute(
github.NamedUser.NamedUser,
attributes["dismissal_restrictions"]["users"],
)
if "teams" in attributes["dismissal_restrictions"]: # pragma no branch
self._teams = self._makeListOfClassesAttribute(
self._dismissal_teams = self._makeListOfClassesAttribute(
github.Team.Team, attributes["dismissal_restrictions"]["teams"]
)
if "dismiss_stale_reviews" in attributes: # pragma no branch
Expand All @@ -123,3 +139,20 @@ def _useAttributes(self, attributes: dict[str, Any]) -> None:
)
if "url" in attributes: # pragma no branch
self._url = self._makeStringAttribute(attributes["url"])
if "bypass_pull_request_allowances" in attributes:
if "users" in attributes["bypass_pull_request_allowances"]:
self._bypass_pull_request_allowances_users = self._makeListOfClassesAttribute(
github.NamedUser.NamedUser,
attributes["bypass_pull_request_allowances"]["users"],
)
if "teams" in attributes["bypass_pull_request_allowances"]:
self._bypass_pull_request_allowances_teams = self._makeListOfClassesAttribute(
github.Team.Team,
attributes["bypass_pull_request_allowances"]["teams"],
)
if "apps" in attributes["bypass_pull_request_allowances"]:
self._bypass_pull_request_allowances_apps = self._makeListOfClassesAttribute(
github.GithubApp.GithubApp,
attributes["bypass_pull_request_allowances"]["apps"],
)