Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mTLS support #2811

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add mTLS support #2811

wants to merge 2 commits into from

Conversation

ukaj
Copy link

@ukaj ukaj commented Nov 6, 2023

Issue:

  • Currently PyGitHub doesn't allow to authenticate using client certs (mTLS), because cert property is not passed to requests call

Example:

gh = Github(cert='/tmp/client_cert.pem')
TypeError: Github.__init__() got an unexpected keyword argument 'cert'

Proposed fix:

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e584a90) 96.74% compared to head (d7496fe) 96.72%.
Report is 34 commits behind head on main.

Files Patch % Lines
github/Auth.py 75.00% 1 Missing ⚠️
github/Requester.py 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2811      +/-   ##
==========================================
- Coverage   96.74%   96.72%   -0.02%     
==========================================
  Files         139      139              
  Lines       14184    14189       +5     
==========================================
+ Hits        13722    13725       +3     
- Misses        462      464       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EnricoMi
Copy link
Collaborator

Does GH or GH Enterprise support mTLS authentication? Can this be combined with any other available authentication like token or login?

@EnricoMi
Copy link
Collaborator

EnricoMi commented Dec 7, 2023

@ukaj ping

@EnricoMi
Copy link
Collaborator

EnricoMi commented Dec 19, 2023

Once we have access to the session of the Requester (#2865), this can be implemented as an auth.Auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants